-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use latest arborist 6 and drop support for node 12 and 14 #925
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do it!
Hi! Is there any progress on this? Thanks in advance. |
@D1X7R4 why, do you need this chang? |
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
BREAKING CHANGE:
tl;dr the only breaking change is that you will no longer be able to install Generator when using Node 12 or 14. This will break pipelines for people.
We need to explicitly require:
Because this is what latest Arborist requires.
Node 12 is already not maintained by node folks, and Node 14 support finishes on April 30, this is why I suggest to also not support Node 14.
TODO: this PR cannot be merged before we update global pipelines to run on Node 16. Different story though. Review and approval of this PR is not blocked by this. You only need to know that this is why tests fail